PYIC-7571: Track verifier use #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of VCs were failing signature verification in staging. Turns out they were signed with an unexpected key. It would be useful to understand how many VCs are signed with this key (which has been added to config). This would also potentially be interesting when we recondile in production to understand the proportion of passport VCs signed with the old and new keys.
It would be good to be able to easily say that we've matchec the same number of VCs as expected, rather than just the number of identities.
|
Joe-Edwards-GDS
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Track verifier use and number of VCs matched
Why did it change
Lots of VCs were failing signature verification in staging. Turns out they were signed with an unexpected key. It would be useful to understand how many VCs are signed with this key (which has been added to config).
This would also potentially be interesting when we recondile in production to understand the proportion of passport VCs signed with the old and new keys.
Also, It would be good to be able to easily say that we've matched the same
number of VCs as expected, rather than just the number of identities.
Issue tracking